rdmbair15m5-changelog-20260922-0340-rev-20260904-01-rtty-sqlite-consolidation

Consolidated duplicate raw SQLite prepare, step, execute, bind, setBusyTimeout, errorMessage, and columnData helpers across RTTy archive stores into internal SQLiteArchiveSupport, eliminating three duplicate definitions of sqliteTransient.

Scope

• Hosts: rdmsm4x (canonical repo ~/dev/apps/RTTy), rdmbair15m5 (local clone ~/dev/apps/RTTy).
• Repositories: apps/RTTy on main.
• Tickets: REV-20260904-01.

Files Touched

• Sources/RTTy/Services/MonitoringArchiveStore.swift: Extracted internal SQLiteArchiveSupport enum containing shared sqliteTransient, prepare, step, execute, setBusyTimeout, bind (String, Data, Double, Int32, Int64), columnData, columnText, columnDouble, columnInt64, and errorMessage. Converted store private helpers to delegate directly.
• Sources/RTTy/Services/ConnectionSpeedTestArchiveStore.swift: Removed duplicate sqliteTransient = unsafeBitCast(-1, to: sqlite3_destructor_type.self). Updated prepare, step, execute, bind, withDatabase, results, and enforceRetention to use SQLiteArchiveSupport.
• Sources/RTTy/Services/PublicEgressHistoryArchiveStore.swift: Removed duplicate sqliteTransient = unsafeBitCast(-1, to: sqlite3_destructor_type.self). Updated prepare, step, execute, bind, withDatabase, observations, latestObservation, and enforceRetention to use SQLiteArchiveSupport.

Commits & Remote Parity

• Commit: 1aae3fd (refactor(storage): consolidate raw SQLite helpers across archive stores (REV-20260904-01))
• Remotes:
  • origin (https://github.com/richhdoty/RTTy.git) -> 1aae3fd
  • fleet (git.ecs0.net:git/apps/RTTy.git) -> 1aae3fd
  • backup (https://github.com/richhdoty/rdmsm4x-dev-apps-rtty.git) -> 1aae3fd
  • Local rdmbair15m5:~/dev/apps/RTTy fast-forwarded to 1aae3fd.

Verification Evidence

• Targeted test suite:
  • MonitoringArchiveStoreTests: 17 passed.
  • ConnectionSpeedTestTests: 5 passed.
  • PublicEgressObservationTests: 4 passed.
  • Total: 26 passed, 0 failures in 1.259s.
• Standard project and closure verification:
  • python3 Tests/ScriptTests/standard_source_reference_closure_test.py: RC 0 (PASS: no unregistered Sources/RTTy type is reachable from the Standard allowlist (70 allowlisted, 12 Direct-only, 57 LatencyCore registered)).
  • bash Tests/ScriptTests/standard_project_test.sh: RC 0 (PASS: Standard PBX source phase exactly matches its reviewed allowlist, PASS: every Standard PBX Sources phase exactly matches its compiler projection, PASS: RTTyStandard project exposes one sandbox-safe macOS application target).
  • python3 Tests/ScriptTests/standard_candidate_closure_test.py: RC 0 (PASS: Standard evidence and source policy close all 137 compiler inputs and the complete build-input projection).
• Full test suite:
  • RTTyTests & LatencyCoreTests executed with 0 failures (rc=0).

Rollback / Undo

• git revert 1aae3fd or git reset --hard c3ecb06.